Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 570b8fb5 authored by Mathieu Desnoyers's avatar Mathieu Desnoyers Committed by James Morris
Browse files

CRED: Fix memory leak in error handling 



Fix a memory leak on an OOM condition in prepare_usermodehelper_creds().

Signed-off-by: default avatarMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarJames Morris <jmorris@namei.org>
parent 9623e5a2

kernel/cred.c

+5 −1
Original line number Diff line number Diff line
@@ -364,7 +364,7 @@ struct cred *prepare_usermodehelper_creds(void) 


	new = kmem_cache_alloc(cred_jar, GFP_ATOMIC);

	if (!new)

		return NULL;

		goto free_tgcred;



	kdebug("prepare_usermodehelper_creds() alloc %p", new);
@@ -397,6 +397,10 @@ struct cred *prepare_usermodehelper_creds(void) 


error:

	put_cred(new);

free_tgcred:

#ifdef CONFIG_KEYS

	kfree(tgcred);

#endif

	return NULL;

}