Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 56c978f1 authored by Herbert Xu's avatar Herbert Xu Committed by David S. Miller
Browse files

net: Remove LL_ALLOCATED_SPACE 



net: Remove LL_ALLOCATED_SPACE

The macro LL_ALLOCATED_SPACE was ill-conceived.  It applies the
alignment to the sum of needed_headroom and needed_tailroom.  As
the amount that is then reserved for head room is needed_headroom
with alignment, this means that the tail room left may be too small.

Now that all uses of LL_ALLOCATED_SPACE have been removed, this
patch finally removes the macro itself.

Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ae641949

include/linux/netdevice.h

+0 −5
Original line number Diff line number Diff line
@@ -279,16 +279,11 @@ struct hh_cache { 
 *

 * We could use other alignment values, but we must maintain the

 * relationship HH alignment <= LL alignment.

 *

 * LL_ALLOCATED_SPACE also takes into account the tailroom the device

 * may need.

 */

#define LL_RESERVED_SPACE(dev) \

	((((dev)->hard_header_len+(dev)->needed_headroom)&~(HH_DATA_MOD - 1)) + HH_DATA_MOD)

#define LL_RESERVED_SPACE_EXTRA(dev,extra) \

	((((dev)->hard_header_len+(dev)->needed_headroom+(extra))&~(HH_DATA_MOD - 1)) + HH_DATA_MOD)

#define LL_ALLOCATED_SPACE(dev) \

	((((dev)->hard_header_len+(dev)->needed_headroom+(dev)->needed_tailroom)&~(HH_DATA_MOD - 1)) + HH_DATA_MOD)



struct header_ops {

	int	(*create) (struct sk_buff *skb, struct net_device *dev,