Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 56497bd5 authored by Tejun Heo's avatar Tejun Heo Committed by Jeff Garzik
Browse files

[PATCH] libata: fix comment regarding setting cable type 



The comment above ata_std_postreset() specified that setting cable
type is the responsibility of postreset(), which isn't possible /
optimal depending on controller / driver.  This patch kills the
comment.  Setting cable type is responsibility of ->probe_reset.
libata doesn't care whether it's done in probeinit, reset or
postreset.

Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
Signed-off-by: default avatarJeff Garzik <jgarzik@pobox.com>
parent 6aff8f1f

drivers/scsi/libata-core.c

+1 −2
Original line number Diff line number Diff line
@@ -2112,7 +2112,6 @@ int sata_std_hardreset(struct ata_port *ap, int verbose, unsigned int *class) 
 *	This function is invoked after a successful reset.  Note that

 *	the device might have been reset more than once using

 *	different reset methods before postreset is invoked.

 *	postreset is also reponsible for setting cable type.

 *

 *	This function is to be used as standard callback for

 *	ata_drive_*_reset().
@@ -2124,7 +2123,7 @@ void ata_std_postreset(struct ata_port *ap, unsigned int *classes) 
{

	DPRINTK("ENTER\n");



	/* set cable type */

	/* set cable type if it isn't already set */

	if (ap->cbl == ATA_CBL_NONE && ap->flags & ATA_FLAG_SATA)

		ap->cbl = ATA_CBL_SATA;