Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5580ba7b authored by Dan Carpenter's avatar Dan Carpenter Committed by Takashi Iwai
Browse files

ALSA: oxfw: some signedness bugs 



This code tends to use unsigned variables by default and it causes
signedness bugs when we use negative variables for error handling.
The "i" and "j" variables are used to iterated over small positive
values and so they should be type "int".  The "len" variable doesn't
*need* to be signed but it should be signed to make the code easier to
read and audit.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 0d3aba30

sound/firewire/oxfw/oxfw-pcm.c

+3 −3
Original line number Diff line number Diff line
@@ -19,7 +19,7 @@ static int hw_rule_rate(struct snd_pcm_hw_params *params, 
		.min = UINT_MAX, .max = 0, .integer = 1

	};

	struct snd_oxfw_stream_formation formation;

	unsigned int i, err;

	int i, err;



	for (i = 0; i < SND_OXFW_STREAM_FORMAT_ENTRIES; i++) {

		if (formats[i] == NULL)
@@ -47,7 +47,7 @@ static int hw_rule_channels(struct snd_pcm_hw_params *params, 
	const struct snd_interval *r =

		hw_param_interval_c(params, SNDRV_PCM_HW_PARAM_RATE);

	struct snd_oxfw_stream_formation formation;

	unsigned int i, j, err;

	int i, j, err;

	unsigned int count, list[SND_OXFW_STREAM_FORMAT_ENTRIES] = {0};



	count = 0;
@@ -80,7 +80,7 @@ static int hw_rule_channels(struct snd_pcm_hw_params *params, 
static void limit_channels_and_rates(struct snd_pcm_hardware *hw, u8 **formats)

{

	struct snd_oxfw_stream_formation formation;

	unsigned int i, err;

	int i, err;



	hw->channels_min = UINT_MAX;

	hw->channels_max = 0;

sound/firewire/oxfw/oxfw-proc.c

+1 −1
Original line number Diff line number Diff line
@@ -15,7 +15,7 @@ static void proc_read_formation(struct snd_info_entry *entry, 
	struct snd_oxfw_stream_formation formation, curr;

	u8 *format;

	char flag;

	unsigned int i, err;

	int i, err;



	/* Show input. */

	err = snd_oxfw_stream_get_current_formation(oxfw,

sound/firewire/oxfw/oxfw-stream.c

+2 −1
Original line number Diff line number Diff line
@@ -61,7 +61,8 @@ static int set_stream_format(struct snd_oxfw *oxfw, struct amdtp_stream *s, 
	u8 **formats;

	struct snd_oxfw_stream_formation formation;

	enum avc_general_plug_dir dir;

	unsigned int i, err, len;

	unsigned int len;

	int i, err;



	if (s == &oxfw->tx_stream) {

		formats = oxfw->tx_stream_formats;