Commit 54dbda74 authored Jan 29, 2017 by Guy Shapiro Committed by Greg Kroah-Hartman Dec 21, 2018

rtc: snvs: add a missing write sync



[ Upstream commit 7bb633b1a9812a6b9f3e49d0cf17f60a633914e5 ]

The clear of the LPTA_EN flag should be synced before writing to the
alarm register. Omitting this synchronization creates a race when
trying to change existing alarm.

Signed-off-by: Guy Shapiro <guy.shapiro@mobi-wize.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 36764b4a

drivers/rtc/rtc-snvs.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -187,6 +187,7 @@ static int snvs_rtc_set_alarm(struct device dev, struct rtc_wkalrm alrm)
		rtc_tm_to_time(alrm_tm, &time);

		regmap_update_bits(data->regmap, data->offset + SNVS_LPCR, SNVS_LPCR_LPTA_EN, 0);
		rtc_write_sync_lp(data);
		regmap_write(data->regmap, data->offset + SNVS_LPTAR, time);

		/* Clear alarm interrupt status bit */