Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 53619b75 authored by Mohammed Javid's avatar Mohammed Javid Committed by Gerrit - the friendly Code Review server
Browse files

msm: ipa3: Fix to validate the user inputs 



Adding code changes to validate user inputs.
Before allocating the NAT entry verifying the
NAT entry size in range or not.

Change-Id: I21147f20a12243af5d21aebdc206703964db2be4
Acked-by: default avatarPraveen Kurapati <pkurapat@qti.qualcomm.com>
Acked-by: default avatarAshok Vuyyuru <avuyyuru@qti.qualcomm.com>
Signed-off-by: default avatarMohammed Javid <mjavid@codeaurora.org>
parent b6bf7795

drivers/platform/msm/ipa/ipa_v2/ipa_nat.c

+14 −0
Original line number Diff line number Diff line
@@ -35,6 +35,13 @@ enum nat_table_type { 
#define NAT_TABLE_ENTRY_SIZE_BYTE 32

#define NAT_INTEX_TABLE_ENTRY_SIZE_BYTE 4



/*

 * Max NAT table entries is limited 1000 entries.

 * Limit the memory size required by user to prevent kernel memory starvation

 */

#define IPA_TABLE_MAX_ENTRIES 1000

#define MAX_ALLOC_NAT_SIZE (IPA_TABLE_MAX_ENTRIES * NAT_TABLE_ENTRY_SIZE_BYTE)



static int ipa_nat_vma_fault_remap(

	 struct vm_area_struct *vma, struct vm_fault *vmf)

{
@@ -270,6 +277,13 @@ int ipa2_allocate_nat_device(struct ipa_ioc_nat_alloc_mem *mem) 
		goto bail;

	}



	if (mem->size > MAX_ALLOC_NAT_SIZE) {

		IPAERR("Trying allocate more size = %zu, Max allowed = %d\n",

				mem->size, MAX_ALLOC_NAT_SIZE);

		result = -EPERM;

		goto bail;

	}



	if (mem->size <= 0 ||

			nat_ctx->is_dev_init == true) {

		IPAERR_RL("Invalid Parameters or device is already init\n");