Commit 530376bf authored Dec 09, 2013 by H Hartley Sweeten Committed by Greg Kroah-Hartman Dec 10, 2013

staging: comedi: ni_at_a2150: fix an always true condition test



As pointed out by the kbuild test robot, and Ian Abbott, the dma >= 0 test
is always true because dma is unsigned. This generates a warn message:

drivers/staging/comedi/drivers/ni_at_a2150.c:715 a2150_attach()
  warn: always true condition '(dma >= 0) => (0-u32max >= 0)'

Fix the test as suggested by Ian Abbott.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent b774930e

drivers/staging/comedi/drivers/ni_at_a2150.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -712,7 +712,7 @@ static int a2150_attach(struct comedi_device dev, struct comedi_devconfig it)
		}
		}

		if (dev->irq && ((dma >= 0 && dma <= 4) \|\| (dma >= 5 && dma <= 7))) {
		if (dev->irq && dma <= 7 && dma != 4) {
		ret = request_dma(dma, dev->board_name);
		if (ret == 0) {
		devpriv->dma = dma;