Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 526bbd2c authored by Nicolin Chen's avatar Nicolin Chen Committed by Greg Kroah-Hartman
Browse files

hwmon: (ina2xx) Fix current value calculation 



[ Upstream commit 38cd989ee38c16388cde89db5b734f9d55b905f9 ]

The current register (04h) has a sign bit at MSB. The comments
for this calculation also mention that it's a signed register.

However, the regval is unsigned type so result of calculation
turns out to be an incorrect value when current is negative.

This patch simply fixes this by adding a casting to s16.

Fixes: 5d389b125186c ("hwmon: (ina2xx) Make calibration register value fixed")
Signed-off-by: default avatarNicolin Chen <nicoleotsuka@gmail.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 696c3ede

drivers/hwmon/ina2xx.c

+1 −1
Original line number Diff line number Diff line
@@ -273,7 +273,7 @@ static int ina2xx_get_value(struct ina2xx_data *data, u8 reg, 
		break;

	case INA2XX_CURRENT:

		/* signed register, result in mA */

		val = regval * data->current_lsb_uA;

		val = (s16)regval * data->current_lsb_uA;

		val = DIV_ROUND_CLOSEST(val, 1000);

		break;

	case INA2XX_CALIBRATION: