Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 525628c7 authored by Byungchul Park's avatar Byungchul Park Committed by Ingo Molnar
Browse files

sched/fair: Modify the comment about lock assumptions in migrate_task_rq_fair() 



The comment describing migrate_task_rq_fair() says that the caller
should hold p->pi_lock. But in some cases the caller can hold
task_rq(p)->lock instead of p->pi_lock. So the comment is broken and
this patch fixes it.

Signed-off-by: default avatarByungchul Park <byungchul.park@lge.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1447806899-20303-1-git-send-email-byungchul.park@lge.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent accaf6ea

kernel/sched/fair.c

+1 −2
Original line number Diff line number Diff line
@@ -5058,8 +5058,7 @@ select_task_rq_fair(struct task_struct *p, int prev_cpu, int sd_flag, int wake_f 
/*

 * Called immediately before a task is migrated to a new cpu; task_cpu(p) and

 * cfs_rq_of(p) references at time of call are still valid and identify the

 * previous cpu.  However, the caller only guarantees p->pi_lock is held; no

 * other assumptions, including the state of rq->lock, should be made.

 * previous cpu. The caller guarantees p->pi_lock or task_rq(p)->lock is held.

 */

static void migrate_task_rq_fair(struct task_struct *p)

{