Commit 521f4082 authored Apr 04, 2016 by Suman Anna Committed by Joerg Roedel Apr 05, 2016

iommu/omap: Remove iopgtable_clear_entry_all() from driver remove



The function iopgtable_clear_entry_all() is used for clearing all
the page table entries. These entries are neither created nor
initialized during the OMAP IOMMU driver probe, and are managed
only when a client device attaches to the IOMMU. So, there is no
need to invoke this function on a driver remove.

Removing this fixes a NULL pointer dereference crash if the IOMMU
device is unbound from the driver with no client device attached
to the IOMMU device.

Signed-off-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>

parent 9735a227

drivers/iommu/omap-iommu.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -987,7 +987,6 @@ static int omap_iommu_remove(struct platform_device *pdev)
		{
		struct omap_iommu *obj = platform_get_drvdata(pdev);

		iopgtable_clear_entry_all(obj);
		omap_iommu_debugfs_remove(obj);

		pm_runtime_disable(obj->dev);