Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 51f07b7e authored by Dave Airlie's avatar Dave Airlie
Browse files

drm/radeon/gem: don't leak a gem object if reserve fails on get tiling (v2) 



Not sure it ever happens in practice, spotted during code review.

spare brace snuck in

Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent ecabd32a

drivers/gpu/drm/radeon/radeon_gem.c

+2 −1
Original line number Diff line number Diff line
@@ -351,9 +351,10 @@ int radeon_gem_get_tiling_ioctl(struct drm_device *dev, void *data, 
	rbo = gobj->driver_private;

	r = radeon_bo_reserve(rbo, false);

	if (unlikely(r != 0))

		return r;

		goto out;

	radeon_bo_get_tiling_flags(rbo, &args->tiling_flags, &args->pitch);

	radeon_bo_unreserve(rbo);

out:

	mutex_lock(&dev->struct_mutex);

	drm_gem_object_unreference(gobj);

	mutex_unlock(&dev->struct_mutex);