Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 51ec811a authored by Paul Walmsley's avatar Paul Walmsley
Browse files

OMAP3: id: add fallthrough warning; fix some CodingStyle issues 



Emit a warning to the console in omap3_check_revision() if that code
cannot determine what type of SoC the system is currently running on.

Remove some extra whitespace, remove some duplicate code, and
add an appropriate comment to a fallthrough case.

Signed-off-by: default avatarPaul Walmsley <paul@pwsan.com>
Cc: Hemant Pedanekar <hemantp@ti.com>
Tested-by: default avatarIgor Grinberg <grinberg@compulab.co.il>
Tested-by: default avatarAbhilash Koyamangalath <abhilash.kv@ti.com>
parent 9ed2ba7a

arch/arm/mach-omap2/id.c

+6 −5
Original line number Diff line number Diff line
@@ -336,6 +336,7 @@ static void __init omap3_check_revision(void) 
			omap_chip.oc |= CHIP_IS_OMAP3630ES1_1;

			break;

		case 2:

		/* FALLTHROUGH */

		default:

			omap_revision = OMAP3630_REV_ES1_2;

			omap_chip.oc |= CHIP_IS_OMAP3630ES1_2;
@@ -349,8 +350,7 @@ static void __init omap3_check_revision(void) 
			omap_revision = TI8168_REV_ES1_0;

			break;

		case 1:

			omap_revision = TI8168_REV_ES1_1;

			break;

		/* FALLTHROUGH */

		default:

			omap_revision = TI8168_REV_ES1_1;

		}
@@ -359,6 +359,7 @@ static void __init omap3_check_revision(void) 
		/* Unknown default to latest silicon rev as default */

		omap_revision =  OMAP3630_REV_ES1_2;

		omap_chip.oc |= CHIP_IS_OMAP3630ES1_2;

		pr_warn("Warning: unknown chip type; assuming OMAP3630ES1.2\n");

	}

}