Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 51a37e9f authored by Xie Yongji's avatar Xie Yongji Committed by Greg Kroah-Hartman
Browse files

drm/virtio: Fix double free on probe failure 



[ Upstream commit cec7f1774605a5ef47c134af62afe7c75c30b0ee ]

The virtio_gpu_init() will free vgdev and vgdev->vbufs on failure.
But such failure will be caught by virtio_gpu_probe() and then
virtio_gpu_release() will be called to do some cleanup which
will free vgdev and vgdev->vbufs again. So let's set dev->dev_private
to NULL to avoid double free.

Signed-off-by: default avatarXie Yongji <xieyongji@bytedance.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20210517084913.403-2-xieyongji@bytedance.com


Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 03aec2c1

drivers/gpu/drm/virtio/virtgpu_kms.c

+1 −0
Original line number Diff line number Diff line
@@ -234,6 +234,7 @@ int virtio_gpu_driver_load(struct drm_device *dev, unsigned long flags) 
err_vbufs:

	vgdev->vdev->config->del_vqs(vgdev->vdev);

err_vqs:

	dev->dev_private = NULL;

	kfree(vgdev);

	return ret;

}