Commit 51549c08 authored Nov 30, 2015 by Masahiro Yamada Committed by Wolfram Sang Dec 14, 2015

i2c: uniphier_f: error out if bus speed is zero



There is code to divide by "bus_speed" some lines below.
To eliminate the possibility of division by zero, bail out if
"clock-frequency" is specified as zero.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

parent ac9b91f3

drivers/i2c/busses/i2c-uniphier-f.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -466,6 +466,11 @@ static int uniphier_fi2c_clk_init(struct device *dev,
		if (of_property_read_u32(np, "clock-frequency", &bus_speed))
		bus_speed = UNIPHIER_FI2C_DEFAULT_SPEED;

		if (!bus_speed) {
		dev_err(dev, "clock-freqyency should not be zero\n");
		return -EINVAL;
		}

		if (bus_speed > UNIPHIER_FI2C_MAX_SPEED)
		bus_speed = UNIPHIER_FI2C_MAX_SPEED;