Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 513d6d7a authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Trond Myklebust
Browse files

pnfs/blocklayout: pass proper file mode to blkdev_get/put 



We generally want to read and write to a block device that's used by
the pNFS block layout client (and even if it's read only the server
has no way of telling us).  Add FMODE_WRITE to the mode argument
so that we don't incorrectly tell the block driver that we want a
read-only open.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@primarydata.com>
parent 2bd3c63a

fs/nfs/blocklayout/dev.c

+2 −2
Original line number Diff line number Diff line
@@ -22,7 +22,7 @@ bl_free_device(struct pnfs_block_dev *dev) 
		kfree(dev->children);

	} else {

		if (dev->bdev)

			blkdev_put(dev->bdev, FMODE_READ);

			blkdev_put(dev->bdev, FMODE_READ | FMODE_WRITE);

	}

}
@@ -200,7 +200,7 @@ bl_parse_simple(struct nfs_server *server, struct pnfs_block_dev *d, 
	if (!dev)

		return -EIO;



	d->bdev = blkdev_get_by_dev(dev, FMODE_READ, NULL);

	d->bdev = blkdev_get_by_dev(dev, FMODE_READ | FMODE_WRITE, NULL);

	if (IS_ERR(d->bdev)) {

		printk(KERN_WARNING "pNFS: failed to open device %d:%d (%ld)\n",

			MAJOR(dev), MINOR(dev), PTR_ERR(d->bdev));