Commit 511e74f3 authored Oct 05, 2012 by Russell King

SERIAL: omap: no need to re-read EFR



There's no need to re-read EFR after we've recently written it; the
register is a configuration register which doesn't change its value
without us writing to it.  The last value which was written to this
register was up->efr.

Removing this re-reading avoids the possibility that we end up with
up->efr having unintended bits set, which should only be temporarily
set when accessing the enhanced features.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

parent d864c03b

drivers/tty/serial/omap-serial.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -873,8 +873,6 @@ serial_omap_set_termios(struct uart_port port, struct ktermios termios,
		serial_out(up, UART_OMAP_MDR1, up->mdr1);

		serial_out(up, UART_LCR, UART_LCR_CONF_MODE_B);

		up->efr = serial_in(up, UART_EFR);
		serial_out(up, UART_EFR, up->efr \| UART_EFR_ECB);

		serial_out(up, UART_LCR, 0);