Commit 50083928 authored Jan 05, 2015 by James Hogan Committed by Ralf Baechle Jan 13, 2015

MIPS: mips-cm: Fix sparse warnings



Sparse emits a bunch of warnings in mips-cm.h due to casting away of
__iomem by the addr_gcr_*() functions:

arch/mips/include/asm/mips-cm.h:134:1: warning: cast removes address space of expression

And subsequent passing of the return values to __raw_readl() and
__raw_writel() in the read_gcr_*() and write_gcr_*() functions:

arch/mips/include/asm/mips-cm.h:134:1: warning: incorrect type in argument 2 (different address spaces)
arch/mips/include/asm/mips-cm.h:134:1:    expected void volatile [noderef] <asn:2>*mem
arch/mips/include/asm/mips-cm.h:134:1:    got unsigned int [usertype] *
arch/mips/include/asm/mips-cm.h:134:1: warning: incorrect type in argument 1 (different address spaces)
arch/mips/include/asm/mips-cm.h:134:1:    expected void const volatile [noderef] <asn:2>*mem
arch/mips/include/asm/mips-cm.h:134:1:    got unsigned int [usertype] *

Fix by adding __iomem to the addr_gcr_*() return type and cast.

Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Paul Burton <paul.burton@imgtec.com>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/8874/


Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

parent c22eacfe

arch/mips/include/asm/mips-cm.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -89,9 +89,9 @@ static inline bool mips_cm_has_l2sync(void)

		/* Macros to ease the creation of register access functions */
		#define BUILD_CM_R_(name, off) \
		static inline u32 *addr_gcr_##name(void) \
		static inline u32 __iomem *addr_gcr_##name(void) \
		{ \
		return (u32 *)(mips_cm_base + (off)); \
		return (u32 __iomem *)(mips_cm_base + (off)); \
		} \
		\
		static inline u32 read_gcr_##name(void) \