Commit 5006b313 authored Aug 20, 2011 by Julia Lawall Committed by Mark Brown Aug 22, 2011

sound/soc/ep93xx/ep93xx-i2s.c: add missing kfree

Introduce a new label that includes kfree and jump to that one.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
identifier x;
expression E1!=0,E2,E3,E4;
statement S;
iterator I;
@@

(
if (...) { ... when != kfree(x)
               when != x = E3
               when != E3 = x
*  return ...;
 }
... when != x = E2
    when != I(...,x,...) S
if (...) { ... when != x = E4
 kfree(x); ... return ...; }
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Alexander Sverdlin <subaparts@yandex.ru>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Acked-by: Liam Girdwood <lrg@ti.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

parent 96101bd0

sound/soc/ep93xx/ep93xx-i2s.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -385,14 +385,14 @@ static int ep93xx_i2s_probe(struct platform_device *pdev)
		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		if (!res) {
		err = -ENODEV;
		goto fail;
		goto fail_free_info;
		}

		info->mem = request_mem_region(res->start, resource_size(res),
		pdev->name);
		if (!info->mem) {
		err = -EBUSY;
		goto fail;
		goto fail_free_info;
		}

		info->regs = ioremap(info->mem->start, resource_size(info->mem));
		@@ -435,6 +435,7 @@ static int ep93xx_i2s_probe(struct platform_device *pdev)
		iounmap(info->regs);
		fail_release_mem:
		release_mem_region(info->mem->start, resource_size(info->mem));
		fail_free_info:
		kfree(info);
		fail:
		return err;