Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4ffd3c73 authored by françois romieu's avatar françois romieu Committed by David S. Miller
Browse files

net: batch of last_rx update avoidance in ethernet drivers. 



None of those drivers uses last_rx for its own needs.

See 4dc89133 ("net: add a comment on
netdev->last_rx") for reference.

Signed-off-by: default avatarFrancois Romieu <romieu@fr.zoreil.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: Wingman Kwok <w-kwok2@ti.com>
Cc: Murali Karicheri <m-karicheri2@ti.com>
Cc: Chris Metcalf <cmetcalf@tilera.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7852dada

drivers/net/ethernet/amd/xgbe/xgbe-drv.c

+0 −1
Original line number Diff line number Diff line
@@ -2072,7 +2072,6 @@ static int xgbe_rx_poll(struct xgbe_channel *channel, int budget) 
		skb_record_rx_queue(skb, channel->queue_index);

		skb_mark_napi_id(skb, napi);



		netdev->last_rx = jiffies;

		napi_gro_receive(napi, skb);



next_packet:

drivers/net/ethernet/hisilicon/hix5hd2_gmac.c

+0 −1
Original line number Diff line number Diff line
@@ -500,7 +500,6 @@ static int hix5hd2_rx(struct net_device *dev, int limit) 
		napi_gro_receive(&priv->napi, skb);

		dev->stats.rx_packets++;

		dev->stats.rx_bytes += skb->len;

		dev->last_rx = jiffies;

next:

		pos = dma_ring_incr(pos, RX_DESC_NUM);

	}

drivers/net/ethernet/intel/i40e/i40e_txrx.c

+0 −2
Original line number Diff line number Diff line
@@ -1688,7 +1688,6 @@ static int i40e_clean_rx_irq_ps(struct i40e_ring *rx_ring, int budget) 
		skb_mark_napi_id(skb, &rx_ring->q_vector->napi);

		i40e_receive_skb(rx_ring, skb, vlan_tag);



		rx_ring->netdev->last_rx = jiffies;

		rx_desc->wb.qword1.status_error_len = 0;



	} while (likely(total_rx_packets < budget));
@@ -1821,7 +1820,6 @@ static int i40e_clean_rx_irq_1buf(struct i40e_ring *rx_ring, int budget) 
#endif

		i40e_receive_skb(rx_ring, skb, vlan_tag);



		rx_ring->netdev->last_rx = jiffies;

		rx_desc->wb.qword1.status_error_len = 0;

	} while (likely(total_rx_packets < budget));

drivers/net/ethernet/intel/i40evf/i40e_txrx.c

+0 −2
Original line number Diff line number Diff line
@@ -1156,7 +1156,6 @@ static int i40e_clean_rx_irq_ps(struct i40e_ring *rx_ring, int budget) 
		skb_mark_napi_id(skb, &rx_ring->q_vector->napi);

		i40e_receive_skb(rx_ring, skb, vlan_tag);



		rx_ring->netdev->last_rx = jiffies;

		rx_desc->wb.qword1.status_error_len = 0;



	} while (likely(total_rx_packets < budget));
@@ -1271,7 +1270,6 @@ static int i40e_clean_rx_irq_1buf(struct i40e_ring *rx_ring, int budget) 
			 : 0;

		i40e_receive_skb(rx_ring, skb, vlan_tag);



		rx_ring->netdev->last_rx = jiffies;

		rx_desc->wb.qword1.status_error_len = 0;

	} while (likely(total_rx_packets < budget));

drivers/net/ethernet/moxa/moxart_ether.c

+0 −1
Original line number Diff line number Diff line
@@ -244,7 +244,6 @@ static int moxart_rx_poll(struct napi_struct *napi, int budget) 
		napi_gro_receive(&priv->napi, skb);

		rx++;



		ndev->last_rx = jiffies;

		priv->stats.rx_packets++;

		priv->stats.rx_bytes += len;

		if (desc0 & RX_DESC0_MULTICAST)