Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4f39fcce authored by Giedrius Statkevičius's avatar Giedrius Statkevičius Committed by Greg Kroah-Hartman
Browse files

power: supply: lp8788: prevent out of bounds array access 



commit bdd9968d35f7fcdb76089347d1529bf079534214 upstream.

val might become 7 in which case stime[7] (array of length 7) would be
accessed during the scnprintf call later and that will cause issues.
Obviously, string concatenation is not intended here so just a comma needs
to be added to fix the issue.

Fixes: 98a27664 ("power_supply: Add new lp8788 charger driver")
Signed-off-by: default avatarGiedrius Statkevičius <giedrius.statkevicius@gmail.com>
Acked-by: default avatarMilo Kim <milo.kim@ti.com>
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ccef31d2

drivers/power/supply/lp8788-charger.c

+1 −1
Original line number Diff line number Diff line
@@ -654,7 +654,7 @@ static ssize_t lp8788_show_eoc_time(struct device *dev, 
{

	struct lp8788_charger *pchg = dev_get_drvdata(dev);

	char *stime[] = { "400ms", "5min", "10min", "15min",

			"20min", "25min", "30min" "No timeout" };

			"20min", "25min", "30min", "No timeout" };

	u8 val;



	lp8788_read_byte(pchg->lp, LP8788_CHG_EOC, &val);