Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4f34337b authored by Alan Cox's avatar Alan Cox Committed by Jeff Garzik
Browse files

libata: Note that our cache flush code needs fixing up 



Remembered this while doing auditing and code review versus the specs

Signed-off-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent 50a99018

drivers/ata/libata-core.c

+4 −0
Original line number Diff line number Diff line
@@ -5906,6 +5906,10 @@ int ata_flush_cache(struct ata_device *dev) 
	else

		cmd = ATA_CMD_FLUSH;



	/* This is wrong. On a failed flush we get back the LBA of the lost

	   sector and we should (assuming it wasn't aborted as unknown) issue

	   a further flush command to continue the writeback until it 

	   does not error */

	err_mask = ata_do_simple_cmd(dev, cmd);

	if (err_mask) {

		ata_dev_printk(dev, KERN_ERR, "failed to flush cache\n");