Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4e18248a authored by Sudip Mukherjee's avatar Sudip Mukherjee Committed by Greg Kroah-Hartman
Browse files

staging: rtl8188eu: remove function which does nothing 



The function rtw_mfree_all_stainfo() is just holding the lock,
traversing the list, and then unlocking. It is not doing anything else.
So removed the function and modified the places from where it was called.

Signed-off-by: default avatarSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9393d34e

drivers/staging/rtl8188eu/core/rtw_sta_mgt.c

+0 −28
Original line number Diff line number Diff line
@@ -143,32 +143,6 @@ inline struct sta_info *rtw_get_stainfo_by_offset(struct sta_priv *stapriv, int 
	return (struct sta_info *)(stapriv->pstainfo_buf + offset * sizeof(struct sta_info));

}



/*  this function is used to free the memory of lock || sema for all stainfos */

static void rtw_mfree_all_stainfo(struct sta_priv *pstapriv)

{

	struct list_head *plist, *phead;

	struct sta_info *psta = NULL;





	spin_lock_bh(&pstapriv->sta_hash_lock);



	phead = get_list_head(&pstapriv->free_sta_queue);

	plist = phead->next;



	while (phead != plist) {

		psta = container_of(plist, struct sta_info, list);

		plist = plist->next;

	}



	spin_unlock_bh(&pstapriv->sta_hash_lock);



}



static void rtw_mfree_sta_priv_lock(struct sta_priv *pstapriv)

{

	 rtw_mfree_all_stainfo(pstapriv); /* be done before free sta_hash_lock */

}



u32	_rtw_free_sta_priv(struct	sta_priv *pstapriv)

{

	struct list_head *phead, *plist;
@@ -197,8 +171,6 @@ u32 _rtw_free_sta_priv(struct sta_priv *pstapriv) 
		spin_unlock_bh(&pstapriv->sta_hash_lock);

		/*===============================*/



		rtw_mfree_sta_priv_lock(pstapriv);



		if (pstapriv->pallocated_stainfo_buf)

			vfree(pstapriv->pallocated_stainfo_buf);

	}