Commit 4dcb8b57 authored Oct 22, 2015 by Mike Snitzer

dm btree: fix leak of bufio-backed block in btree_split_beneath error path



btree_split_beneath()'s error path had an outstanding FIXME that speaks
directly to the potential for _not_ cleaning up a previously allocated
bufio-backed block.

Fix this by releasing the previously allocated bufio block using
unlock_block().

Reported-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Acked-by: Joe Thornber <thornber@redhat.com>
Cc: stable@vger.kernel.org

parent 2871c69e

drivers/md/persistent-data/dm-btree.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -523,7 +523,7 @@ static int btree_split_beneath(struct shadow_spine *s, uint64_t key)

		r = new_block(s->info, &right);
		if (r < 0) {
		/* FIXME: put left */
		unlock_block(s->info, left);
		return r;
		}