Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4d8729a1 authored by Dan Carpenter's avatar Dan Carpenter Committed by Bryan Wu
Browse files

LEDS: memory leak in blinkm_led_common_set() 



This can return without freeing the bl_work struct.  Also there was no
check for allocation failure.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarJan-Simon Möller <jansimon.moeller@gmx.de>
Signed-off-by: default avatarBryan Wu <bryan.wu@canonical.com>
parent eb80411b

drivers/leds/leds-blinkm.c

+5 −2
Original line number Diff line number Diff line
@@ -468,8 +468,7 @@ static int blinkm_led_common_set(struct led_classdev *led_cdev, 
	/* led_brightness is 0, 127 or 255 - we just use it here as-is */

	struct blinkm_led *led = cdev_to_blmled(led_cdev);

	struct blinkm_data *data = i2c_get_clientdata(led->i2c_client);

	struct blinkm_work *bl_work = kzalloc(sizeof(struct blinkm_work),

					      GFP_ATOMIC);

	struct blinkm_work *bl_work;



	switch (color) {

	case RED:
@@ -511,6 +510,10 @@ static int blinkm_led_common_set(struct led_classdev *led_cdev, 
		return -EINVAL;

	}



	bl_work = kzalloc(sizeof(*bl_work), GFP_ATOMIC);

	if (!bl_work)

		return -ENOMEM;



	atomic_inc(&led->active);

	dev_dbg(&led->i2c_client->dev,

			"#TO_SCHED# next_red = %d, next_green = %d,"