Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4cfd8d53 authored by Tudor Ambarus's avatar Tudor Ambarus Committed by Greg Kroah-Hartman
Browse files

dmaengine: at_hdmac: Check return code of dma_async_device_register 



commit c47e6403fa099f200868d6b106701cb42d181d2b upstream.

dma_async_device_register() can fail, check the return code and display an
error.

Fixes: dc78baa2 ("dmaengine: at_hdmac: new driver for the Atmel AHB DMA Controller")
Signed-off-by: default avatarTudor Ambarus <tudor.ambarus@microchip.com>
Cc: stable@vger.kernel.org
Acked-by: default avatarNicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20221025090306.297886-1-tudor.ambarus@microchip.com
Link: https://lore.kernel.org/r/20221025090306.297886-16-tudor.ambarus@microchip.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6163e5b6

drivers/dma/at_hdmac.c

+6 −1
Original line number Diff line number Diff line
@@ -2092,7 +2092,11 @@ static int __init at_dma_probe(struct platform_device *pdev) 
	  dma_has_cap(DMA_SG, atdma->dma_common.cap_mask)  ? "sg-cpy " : "",

	  plat_dat->nr_channels);



	dma_async_device_register(&atdma->dma_common);

	err = dma_async_device_register(&atdma->dma_common);

	if (err) {

		dev_err(&pdev->dev, "Unable to register: %d.\n", err);

		goto err_dma_async_device_register;

	}



	/*

	 * Do not return an error if the dmac node is not present in order to
@@ -2112,6 +2116,7 @@ static int __init at_dma_probe(struct platform_device *pdev) 


err_of_dma_controller_register:

	dma_async_device_unregister(&atdma->dma_common);

err_dma_async_device_register:

	dma_pool_destroy(atdma->memset_pool);

err_memset_pool_create:

	dma_pool_destroy(atdma->dma_desc_pool);