Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4bb5eba0 authored by Ben Dooks's avatar Ben Dooks Committed by Linus Torvalds
Browse files

spi: spi_s3c24xx driver must init completion 



The s3c24xx_spi_txrx() function should initialise the completion each time
before using it, otherwise we end up with the possibility of returning success
before the interrupt handler has processed all the data.

Signed-off-by: default avatarBen Dooks <ben-linux@fluff.org>
Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 335e92e8

drivers/spi/spi_s3c24xx.c

+3 −0
Original line number Diff line number Diff line
@@ -192,8 +192,11 @@ static int s3c24xx_spi_txrx(struct spi_device *spi, struct spi_transfer *t) 
	hw->len = t->len;

	hw->count = 0;



	init_completion(&hw->done);



	/* send the first byte */

	writeb(hw_txbyte(hw, 0), hw->regs + S3C2410_SPTDAT);



	wait_for_completion(&hw->done);



	return hw->count;