Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4b19b78a authored by Saurabh Sengar's avatar Saurabh Sengar Committed by Peter Chen
Browse files

usb: chipidea: removing of_find_property 



call to of_find_property() before of_property_read_u32() is unnecessary.
of_property_read_u32() anyway calls to of_find_property() only.

Signed-off-by: default avatarSaurabh Sengar <saurabh.truth@gmail.com>
Signed-off-by: default avatarPeter Chen <peter.chen@freescale.com>
parent b09b5224

drivers/usb/chipidea/core.c

+22 −35
Original line number Diff line number Diff line
@@ -686,52 +686,39 @@ static int ci_get_platdata(struct device *dev, 
	if (usb_get_maximum_speed(dev) == USB_SPEED_FULL)

		platdata->flags |= CI_HDRC_FORCE_FULLSPEED;



	if (of_find_property(dev->of_node, "phy-clkgate-delay-us", NULL))

	of_property_read_u32(dev->of_node, "phy-clkgate-delay-us",

				     &platdata->phy_clkgate_delay_us);



	platdata->itc_setting = 1;

	if (of_find_property(dev->of_node, "itc-setting", NULL)) {

		ret = of_property_read_u32(dev->of_node, "itc-setting",



	of_property_read_u32(dev->of_node, "itc-setting",

					&platdata->itc_setting);

		if (ret) {

			dev_err(dev,

				"failed to get itc-setting\n");

			return ret;

		}

	}



	if (of_find_property(dev->of_node, "ahb-burst-config", NULL)) {

	ret = of_property_read_u32(dev->of_node, "ahb-burst-config",

				&platdata->ahb_burst_config);

		if (ret) {

			dev_err(dev,

				"failed to get ahb-burst-config\n");

			return ret;

		}

	if (!ret) {

		platdata->flags |= CI_HDRC_OVERRIDE_AHB_BURST;

	} else if (ret != -EINVAL) {

		dev_err(dev, "failed to get ahb-burst-config\n");

		return ret;

	}



	if (of_find_property(dev->of_node, "tx-burst-size-dword", NULL)) {

	ret = of_property_read_u32(dev->of_node, "tx-burst-size-dword",

				&platdata->tx_burst_size);

		if (ret) {

			dev_err(dev,

				"failed to get tx-burst-size-dword\n");

			return ret;

		}

	if (!ret) {

		platdata->flags |= CI_HDRC_OVERRIDE_TX_BURST;

	} else if (ret != -EINVAL) {

		dev_err(dev, "failed to get tx-burst-size-dword\n");

		return ret;

	}



	if (of_find_property(dev->of_node, "rx-burst-size-dword", NULL)) {

	ret = of_property_read_u32(dev->of_node, "rx-burst-size-dword",

				&platdata->rx_burst_size);

		if (ret) {

			dev_err(dev,

				"failed to get rx-burst-size-dword\n");

			return ret;

		}

	if (!ret) {

		platdata->flags |= CI_HDRC_OVERRIDE_RX_BURST;

	} else if (ret != -EINVAL) {

		dev_err(dev, "failed to get rx-burst-size-dword\n");

		return ret;

	}



	ext_id = ERR_PTR(-ENODEV);