Commit 4ad5e883 authored Apr 26, 2016 by Andrew Donnellan Committed by Michael Ellerman Apr 27, 2016

powerpc/mpic: handle subsys_system_register() failure



mpic_init_sys() currently doesn't check whether
subsys_system_register() succeeded or not. Check the return code of
subsys_system_register() and clean up if there's an error.

Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent 2d521784

arch/powerpc/sysdev/mpic.c

+8 −1

Original line number	Diff line number	Diff line
		@@ -2004,8 +2004,15 @@ static struct syscore_ops mpic_syscore_ops = {

		static int mpic_init_sys(void)
		{
		int rc;

		register_syscore_ops(&mpic_syscore_ops);
		subsys_system_register(&mpic_subsys, NULL);
		rc = subsys_system_register(&mpic_subsys, NULL);
		if (rc) {
		unregister_syscore_ops(&mpic_syscore_ops);
		pr_err("mpic: Failed to register subsystem!\n");
		return rc;
		}

		return 0;
		}