Commit 4a7e0231 authored May 25, 2017 by Tudor-Dan Ambarus Committed by Greg Kroah-Hartman Nov 24, 2017

crypto: dh - fix memleak in setkey



commit ee34e2644a78e2561742bea8c4bdcf83cabf90a7 upstream.

setkey can be called multiple times during the existence
of the transformation object. In case of multiple setkey calls,
the old key was not freed and we leaked memory.
Free the old MPI key if any.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 67b718fc

crypto/dh.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -84,6 +84,9 @@ static int dh_set_secret(struct crypto_kpp tfm, void buf, unsigned int len)
		struct dh_ctx *ctx = dh_get_ctx(tfm);
		struct dh params;

		/* Free the old MPI key if any */
		dh_free_ctx(ctx);

		if (crypto_dh_decode_key(buf, len, &params) < 0)
		return -EINVAL;