Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4a0ba216 authored by Maheshwar Ajja's avatar Maheshwar Ajja
Browse files

msm: vidc: Don't assume session error as sys error 



Currently driver assumes all session errors as
sys error. Sys error releases video core which
is not required in case of session errors.
So treat session error as session error only
instead of sys error.

CRs-Fixed: 2138904
Change-Id: I848aad12b07ac547a7073fecbc9b264b5c9b1289
Signed-off-by: default avatarMaheshwar Ajja <majja@codeaurora.org>
parent f797d13b

drivers/media/platform/msm/vidc/hfi_response_handler.c

+3 −4
Original line number Diff line number Diff line
@@ -348,11 +348,10 @@ static int hfi_process_session_error(u32 device_id, 
		info->response_type = HAL_RESPONSE_UNUSED;

		break;

	default:

		/* All other errors are not expected and treated as sys error */

		dprintk(VIDC_ERR,

			"%s: data1 %#x, data2 %#x, treat as sys error\n",

			__func__, pkt->event_data1, pkt->event_data2);

		info->response_type = HAL_SYS_ERROR;

			"%s: session %x data1 %#x, data2 %#x\n", __func__,

			pkt->session_id, pkt->event_data1, pkt->event_data2);

		info->response_type = HAL_SESSION_ERROR;

		break;

	}

drivers/media/platform/msm/vidc/msm_vidc_common.c

+1 −1
Original line number Diff line number Diff line
@@ -5597,7 +5597,7 @@ int msm_comm_kill_session(struct msm_vidc_inst *inst) 
	}



	dprintk(VIDC_WARN, "%s: inst %pK, session %x state %d\n", __func__,

			inst, inst->state, hash32_ptr(inst->session));

			inst, hash32_ptr(inst->session), inst->state);

	/*

	 * We're internally forcibly killing the session, if fw is aware of

	 * the session send session_abort to firmware to clean up and release