Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 48a8d5e8 authored by Noralf Trønnes's avatar Noralf Trønnes Committed by Gerrit - the friendly Code Review server
Browse files

drm/file: Don't set master on in-kernel clients 



It only makes sense for userspace clients.

Signed-off-by: default avatarNoralf Trønnes <noralf@tronnes.org>
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20180618141739.48151-3-noralf@tronnes.org


Patch-mainline: 20180618141739.48151-3-noralf@tronnes.org @ 18/06/18, 02:17 p.m.
[stalek@codeaurora.org: initialize return variable to fix compilation issue.].

Change-Id: Ic2cad4c5e42fb9daf362945d4f20ead3b78b4d8a
Signed-off-by: default avatarShubham Talekar <stalek@codeaurora.org>
parent 273817c6

drivers/gpu/drm/drm_fops.c

+8 −12
Original line number Diff line number Diff line
@@ -141,17 +141,8 @@ struct drm_file *drm_file_alloc(struct drm_minor *minor) 
			goto out_prime_destroy;

	}



	if (drm_is_primary_client(file)) {

		ret = drm_master_open(file);

		if (ret)

			goto out_close;

	}



	return file;



out_close:

	if (dev->driver->postclose)

		dev->driver->postclose(dev, file);

out_prime_destroy:

	if (drm_core_check_feature(dev, DRIVER_PRIME))

		drm_prime_destroy_file_private(&file->prime);
@@ -351,6 +342,7 @@ static int drm_open_helper(struct file *filp, struct drm_minor *minor) 
{

	struct drm_device *dev = minor->dev;

	struct drm_file *priv;

	int ret = 0;



	if (filp->f_flags & O_EXCL)

		return -EBUSY;	/* No exclusive opens */
@@ -361,9 +353,13 @@ static int drm_open_helper(struct file *filp, struct drm_minor *minor) 


	DRM_DEBUG("pid = %d, minor = %d\n", task_pid_nr(current), minor->index);



	priv = drm_file_alloc(minor);

	if (IS_ERR(priv))

		return PTR_ERR(priv);

	if (drm_is_primary_client(priv)) {

		ret = drm_master_open(priv);

		if (ret) {

			drm_file_free(priv);

			return ret;

		}

	}



	filp->private_data = priv;

	filp->f_mode |= FMODE_UNSIGNED_OFFSET;