Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 48924e42 authored by Tomasz Figa's avatar Tomasz Figa Committed by Vinod Koul
Browse files

dmaengine: PL08x: Move LLI dumping code into separate function 



This patch refactors debugging code that dumps LLI entries by moving it
into separate function, which is stubbed when VERBOSE_DEBUG is not
selected. This allows us to get rid of the ugly ifdef from the body of
pl08x_fill_llis_for_desc().

No functional change is introduced by this patch.

Signed-off-by: default avatarTomasz Figa <tomasz.figa@gmail.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent ba6785ff

drivers/dma/amba-pl08x.c

+24 −17
Original line number Diff line number Diff line
@@ -814,6 +814,29 @@ static inline void prep_byte_width_lli(struct pl08x_driver_data *pl08x, 
	(*total_bytes) += len;

}



#ifdef VERBOSE_DEBUG

static void pl08x_dump_lli(struct pl08x_driver_data *pl08x,

			   const u32 *llis_va, int num_llis)

{

	int i;



	dev_vdbg(&pl08x->adev->dev,

		"%-3s %-9s  %-10s %-10s %-10s %s\n",

		"lli", "", "csrc", "cdst", "clli", "cctl");

	for (i = 0; i < num_llis; i++) {

		dev_vdbg(&pl08x->adev->dev,

			"%3d @%p: 0x%08x 0x%08x 0x%08x 0x%08x\n",

			i, llis_va, llis_va[PL080_LLI_SRC],

			llis_va[PL080_LLI_DST], llis_va[PL080_LLI_LLI],

			llis_va[PL080_LLI_CCTL]);

		llis_va += pl08x->lli_words;

	}

}

#else

static inline void pl08x_dump_lli(struct pl08x_driver_data *pl08x,

				  const u32 *llis_va, int num_llis) {}

#endif



/*

 * This fills in the table of LLIs for the transfer descriptor

 * Note that we assume we never have to change the burst sizes
@@ -1033,23 +1056,7 @@ static int pl08x_fill_llis_for_desc(struct pl08x_driver_data *pl08x, 
	/* The final LLI element shall also fire an interrupt. */

	last_lli[PL080_LLI_CCTL] |= PL080_CONTROL_TC_IRQ_EN;



#ifdef VERBOSE_DEBUG

	{

		int i;



		dev_vdbg(&pl08x->adev->dev,

			 "%-3s %-9s  %-10s %-10s %-10s %s\n",

			 "lli", "", "csrc", "cdst", "clli", "cctl");

		for (i = 0; i < num_llis; i++) {

			dev_vdbg(&pl08x->adev->dev,

				 "%3d @%p: 0x%08x 0x%08x 0x%08x 0x%08x\n",

				 i, llis_va, llis_va[PL080_LLI_SRC],

				 llis_va[PL080_LLI_DST], llis_va[PL080_LLI_LLI],

				 llis_va[PL080_LLI_CCTL]);

			llis_va += pl08x->lli_words;

		}

	}

#endif

	pl08x_dump_lli(pl08x, llis_va, num_llis);



	return num_llis;

}