Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 48900cb6 authored by Jason Wang's avatar Jason Wang Committed by David S. Miller
Browse files

virtio-net: drop NETIF_F_FRAGLIST 



virtio declares support for NETIF_F_FRAGLIST, but assumes
that there are at most MAX_SKB_FRAGS + 2 fragments which isn't
always true with a fraglist.

A longer fraglist in the skb will make the call to skb_to_sgvec overflow
the sg array, leading to memory corruption.

Drop NETIF_F_FRAGLIST so we only get what we can handle.

Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
Acked-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4f7eb70f

drivers/net/virtio_net.c

+2 −2
Original line number Diff line number Diff line
@@ -1756,9 +1756,9 @@ static int virtnet_probe(struct virtio_device *vdev) 
	/* Do we support "hardware" checksums? */

	if (virtio_has_feature(vdev, VIRTIO_NET_F_CSUM)) {

		/* This opens up the world of extra features. */

		dev->hw_features |= NETIF_F_HW_CSUM|NETIF_F_SG|NETIF_F_FRAGLIST;

		dev->hw_features |= NETIF_F_HW_CSUM | NETIF_F_SG;

		if (csum)

			dev->features |= NETIF_F_HW_CSUM|NETIF_F_SG|NETIF_F_FRAGLIST;

			dev->features |= NETIF_F_HW_CSUM | NETIF_F_SG;



		if (virtio_has_feature(vdev, VIRTIO_NET_F_GSO)) {

			dev->hw_features |= NETIF_F_TSO | NETIF_F_UFO