Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 484e389c authored by Miklos Szeredi's avatar Miklos Szeredi Committed by Linus Torvalds
Browse files

[PATCH] set mnt_namespace in the correct place 



This patch sets ->mnt_namespace where it's actually added to the
namespace.

Previously mnt_namespace was set in do_kern_mount() even if the filesystem
was never added to any process's namespace (most kernel-internal
filesystems).

This discrepancy doesn't actually cause any problems, but it's cleaner if
mnt_namespace is NULL for these non exported filesystems.

Signed-off-by: default avatarMiklos Szeredi <miklos@szeredi.hu>
Acked-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent ac081153

fs/namespace.c

+1 −0
Original line number Diff line number Diff line
@@ -808,6 +808,7 @@ int do_add_mount(struct vfsmount *newmnt, struct nameidata *nd, 
		goto unlock;



	newmnt->mnt_flags = mnt_flags;

	newmnt->mnt_namespace = current->namespace;

	err = graft_tree(newmnt, nd);



	if (err == 0 && fslist) {

fs/super.c

+0 −1
Original line number Diff line number Diff line
@@ -840,7 +840,6 @@ do_kern_mount(const char *fstype, int flags, const char *name, void *data) 
	mnt->mnt_root = dget(sb->s_root);

	mnt->mnt_mountpoint = sb->s_root;

	mnt->mnt_parent = mnt;

	mnt->mnt_namespace = current->namespace;

	up_write(&sb->s_umount);

	free_secdata(secdata);

	put_filesystem(type);