Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 483aca92 authored by Kefeng Wang's avatar Kefeng Wang Committed by Greg Kroah-Hartman
Browse files

tty/serial: digicolor: Fix digicolor-usart already registered warning 



[ Upstream commit c7ad9ba0611c53cfe194223db02e3bca015f0674 ]

When modprobe/rmmod/modprobe module, if platform_driver_register() fails,
the kernel complained,

  proc_dir_entry 'driver/digicolor-usart' already registered
  WARNING: CPU: 1 PID: 5636 at fs/proc/generic.c:360 proc_register+0x19d/0x270

Fix this by adding uart_unregister_driver() when platform_driver_register() fails.

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarKefeng Wang <wangkefeng.wang@huawei.com>
Acked-by: default avatarBaruch Siach <baruch@tkos.co.il>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent e69bea97

drivers/tty/serial/digicolor-usart.c

+5 −1
Original line number Diff line number Diff line
@@ -545,7 +545,11 @@ static int __init digicolor_uart_init(void) 
	if (ret)

		return ret;



	return platform_driver_register(&digicolor_uart_platform);

	ret = platform_driver_register(&digicolor_uart_platform);

	if (ret)

		uart_unregister_driver(&digicolor_uart);



	return ret;

}

module_init(digicolor_uart_init);