Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 48367c86 authored by Zizhuang Deng's avatar Zizhuang Deng Committed by Greg Kroah-Hartman
Browse files

iio: dac: ad5592r: Fix the missing return value. 



commit b55b38f7cc12da3b9ef36e7a3b7f8f96737df4d5 upstream.

The third call to `fwnode_property_read_u32` did not record
the return value, resulting in `channel_offstate` possibly
being assigned the wrong value.

Fixes: 56ca9db8 ("iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs")
Signed-off-by: default avatarZizhuang Deng <sunsetdzz@gmail.com>
Link: https://lore.kernel.org/r/20220310125450.4164164-1-sunsetdzz@gmail.com


Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 60eb65df

drivers/iio/dac/ad5592r-base.c

+1 −1
Original line number Diff line number Diff line
@@ -532,7 +532,7 @@ static int ad5592r_alloc_channels(struct ad5592r_state *st) 
		if (!ret)

			st->channel_modes[reg] = tmp;



		fwnode_property_read_u32(child, "adi,off-state", &tmp);

		ret = fwnode_property_read_u32(child, "adi,off-state", &tmp);

		if (!ret)

			st->channel_offstate[reg] = tmp;

	}