Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 481e46fe authored by Suzuki K Poulose's avatar Suzuki K Poulose Committed by Greg Kroah-Hartman
Browse files

coresight: Remove erroneous dma_free_coherent in tmc_probe 



commit de546197 ("coresight: tmc: allocating memory when needed")
removed the static allocation of buffer for the trace data in ETR mode in
tmc_probe. However it failed to remove the "devm_free_coherent" in
tmc_probe when the probe fails due to other reasons. This patch gets
rid of the incorrect dma_free_coherent() call.

Fixes: commit de546197 ("coresight: tmc: allocating memory when needed")
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: default avatarSuzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b1149ad9

drivers/hwtracing/coresight/coresight-tmc.c

+0 −3
Original line number Diff line number Diff line
@@ -388,9 +388,6 @@ static int tmc_probe(struct amba_device *adev, const struct amba_id *id) 
err_misc_register:

	coresight_unregister(drvdata->csdev);

err_devm_kzalloc:

	if (drvdata->config_type == TMC_CONFIG_TYPE_ETR)

		dma_free_coherent(dev, drvdata->size,

				drvdata->vaddr, drvdata->paddr);

	return ret;

}