Commit 4818e856 authored May 28, 2015 by Ivan Vecera Committed by David S. Miller May 30, 2015

bna: fix soft lock-up during firmware initialization failure



Bug in the driver initialization causes soft-lockup if firmware
initialization timeout is reached. Polling function bfa_ioc_poll_fwinit()
incorrectly calls bfa_nw_iocpf_timeout() when the timeout is reached.
The problem is that bfa_nw_iocpf_timeout() calls again
bfa_ioc_poll_fwinit()... etc. The bfa_ioc_poll_fwinit() should directly
send timeout event for iocpf and the same should be done if firmware
download into HW fails.

Cc: Rasesh Mody <rasesh.mody@qlogic.com>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 4918eb1e

drivers/net/ethernet/brocade/bna/bfa_ioc.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -2414,7 +2414,7 @@ bfa_ioc_boot(struct bfa_ioc *ioc, enum bfi_fwboot_type boot_type,
		if (status == BFA_STATUS_OK)
		bfa_ioc_lpu_start(ioc);
		else
		bfa_nw_iocpf_timeout(ioc);
		bfa_fsm_send_event(&ioc->iocpf, IOCPF_E_TIMEOUT);

		return status;
		}
		@@ -3029,7 +3029,7 @@ bfa_ioc_poll_fwinit(struct bfa_ioc *ioc)
		}

		if (ioc->iocpf.poll_time >= BFA_IOC_TOV) {
		bfa_nw_iocpf_timeout(ioc);
		bfa_fsm_send_event(&ioc->iocpf, IOCPF_E_TIMEOUT);
		} else {
		ioc->iocpf.poll_time += BFA_IOC_POLL_TOV;
		mod_timer(&ioc->iocpf_timer, jiffies +