Commit 48131dd0 authored Jan 12, 2017 by Tobias Klauser Committed by Greg Kroah-Hartman Jul 05, 2017

x86/mpx: Use compatible types in comparison to fix sparse error




[ Upstream commit 453828625731d0ba7218242ef6ec88f59408f368 ]

info->si_addr is of type void __user *, so it should be compared against
something from the same address space.

This fixes the following sparse error:

  arch/x86/mm/mpx.c:296:27: error: incompatible types in comparison expression (different address spaces)

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 28399407

arch/x86/mm/mpx.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -293,7 +293,7 @@ siginfo_t mpx_generate_siginfo(struct pt_regs regs)
		* We were not able to extract an address from the instruction,
		* probably because there was something invalid in it.
		*/
		if (info->si_addr == (void *)-1) {
		if (info->si_addr == (void __user *)-1) {
		err = -EINVAL;
		goto err_out;
		}