Commit 47be10a1 authored Aug 07, 2019 by Sakari Ailus Committed by Greg Kroah-Hartman Oct 05, 2019

media: omap3isp: Don't set streaming state on random subdevs



[ Upstream commit 7ef57be07ac146e70535747797ef4aee0f06e9f9 ]

The streaming state should be set to the first upstream sub-device only,
not everywhere, for a sub-device driver itself knows how to best control
the streaming state of its own upstream sub-devices.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent d5517d44

drivers/media/platform/omap3isp/isp.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -726,6 +726,10 @@ static int isp_pipeline_enable(struct isp_pipeline *pipe,
		s_stream, mode);
		pipe->do_propagation = true;
		}

		/* Stop at the first external sub-device. */
		if (subdev->dev != isp->dev)
		break;
		}

		return 0;
		@@ -840,6 +844,10 @@ static int isp_pipeline_disable(struct isp_pipeline *pipe)
		&subdev->entity);
		failure = -ETIMEDOUT;
		}

		/* Stop at the first external sub-device. */
		if (subdev->dev != isp->dev)
		break;
		}

		return failure;