Commit 46ac2f53 authored Apr 14, 2015 by Thomas Gleixner

net: core: pktgen: Remove bogus hrtimer_active() check

The check for hrtimer_active() after starting the timer is
pointless. If the timer is inactive it has expired already and
therefor the task pointer is already NULL.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Cc: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Acked-by: David S. Miller <davem@davemloft.net>
Link: http://lkml.kernel.org/r/20150414203503.165258315@linutronix.de

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent ccdd92c1

net/core/pktgen.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -2212,8 +2212,6 @@ static void spin(struct pktgen_dev *pkt_dev, ktime_t spin_until)
		do {
		set_current_state(TASK_INTERRUPTIBLE);
		hrtimer_start_expires(&t.timer, HRTIMER_MODE_ABS);
		if (!hrtimer_active(&t.timer))
		t.task = NULL;

		if (likely(t.task))
		schedule();