Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4694153c authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf ui hist browser: Fixup key bindings 



To match what is shown when '?' or 'H' is pressed, i.e. the keybind help
window.

Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
LKML-Reference: <new-submission>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 59e8fe32

tools/perf/util/ui/browsers/hists.c

+7 −8
Original line number Original line Diff line number Diff line
@@ -215,12 +215,12 @@ static int hist_browser__run(struct hist_browser *self, const char *title, 
			     "Press '?' for help on key bindings") < 0)

			     "Press '?' for help on key bindings") < 0)

		return -1;

		return -1;





	newtFormAddHotKey(self->b.form, 'A');

	newtFormAddHotKey(self->b.form, 'a');

	newtFormAddHotKey(self->b.form, 'a');

	newtFormAddHotKey(self->b.form, '?');

	newtFormAddHotKey(self->b.form, '?');

	newtFormAddHotKey(self->b.form, 'h');

	newtFormAddHotKey(self->b.form, 'h');

	newtFormAddHotKey(self->b.form, 'H');

	newtFormAddHotKey(self->b.form, 'd');

	newtFormAddHotKey(self->b.form, 'd');

	newtFormAddHotKey(self->b.form, 'D');

	newtFormAddHotKey(self->b.form, 't');





	newtFormAddHotKey(self->b.form, NEWT_KEY_LEFT);

	newtFormAddHotKey(self->b.form, NEWT_KEY_LEFT);

	newtFormAddHotKey(self->b.form, NEWT_KEY_RIGHT);

	newtFormAddHotKey(self->b.form, NEWT_KEY_RIGHT);
@@ -232,7 +232,7 @@ static int hist_browser__run(struct hist_browser *self, const char *title, 
		if (es->reason != NEWT_EXIT_HOTKEY)

		if (es->reason != NEWT_EXIT_HOTKEY)

			break;

			break;

		switch (es->u.key) {

		switch (es->u.key) {

		case 'd': { /* Debug */

		case 'D': { /* Debug */

			static int seq;

			static int seq;

			struct hist_entry *h = rb_entry(self->b.top,

			struct hist_entry *h = rb_entry(self->b.top,

							struct hist_entry, rb_node);

							struct hist_entry, rb_node);
@@ -771,18 +771,17 @@ int hists__browse(struct hists *self, const char *helpline, const char *ev_name) 
			default:;

			default:;

			}

			}





			key = toupper(key);

			switch (key) {

			switch (key) {

			case 'A':

			case 'a':

				if (browser->selection->map == NULL &&

				if (browser->selection->map == NULL &&

				    browser->selection->map->dso->annotate_warned)

				    browser->selection->map->dso->annotate_warned)

					continue;

					continue;

				goto do_annotate;

				goto do_annotate;

			case 'D':

			case 'd':

				goto zoom_dso;

				goto zoom_dso;

			case 'T':

			case 't':

				goto zoom_thread;

				goto zoom_thread;

			case 'H':

			case 'h':

			case '?':

			case '?':

do_help:

do_help:

				ui__help_window("->        Zoom into DSO/Threads & Annotate current symbol\n"

				ui__help_window("->        Zoom into DSO/Threads & Annotate current symbol\n"