Commit 464b01a4 authored Oct 22, 2015 by Arnaldo Carvalho de Melo

perf ui tui: Register the error callbacks before initializing the widgets

I.e. we want to tell the user about errors found during, for instance,
the ui_browser initialization, so that a call to ui__warning() appears
as a window waiting for a key to be pressed.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-ederrwizcl6mfz10vfobl5qq@git.kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 39ff7cdb

tools/perf/ui/tui/setup.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -141,10 +141,6 @@ int ui__init(void)

		SLkp_define_keysym((char *)"^(kB)", SL_KEY_UNTAB);

		ui_helpline__init();
		ui_browser__init();
		tui_progress__init();

		signal(SIGSEGV, ui__signal_backtrace);
		signal(SIGFPE, ui__signal_backtrace);
		signal(SIGINT, ui__signal);
		@@ -153,6 +149,10 @@ int ui__init(void)

		perf_error__register(&perf_tui_eops);

		ui_helpline__init();
		ui_browser__init();
		tui_progress__init();

		hist_browser__init_hpp();
		out:
		return err;