Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4644efab authored by Julia Lawall's avatar Julia Lawall Committed by James Bottomley
Browse files

[SCSI] bfa: eliminate useless code 

The variable bfa_itnim is initialized twice to the same (side effect-free)
expression.  Drop one initialization.

A simplified version of the semantic match that finds this problem is:
(http://coccinelle.lip6.fr/

)

// <smpl>
@forall@
idexpression *x;
identifier f!=ERR_PTR;
@@

x = f(...)
... when != x
(
x = f(...,<+...x...+>,...)
|
* x = f(...)
)
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Acked-by: default avatarJing Huang <huangj@brocade.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent f3d6e1dc

drivers/scsi/bfa/bfad_im.c

+0 −1
Original line number Diff line number Diff line
@@ -252,7 +252,6 @@ bfad_im_target_reset_send(struct bfad_s *bfad, struct scsi_cmnd *cmnd, 
	struct bfa_itnim_s *bfa_itnim;

	bfa_status_t    rc = BFA_STATUS_OK;



	bfa_itnim = bfa_fcs_itnim_get_halitn(&itnim->fcs_itnim);

	tskim = bfa_tskim_alloc(&bfad->bfa, (struct bfad_tskim_s *) cmnd);

	if (!tskim) {

		BFA_DEV_PRINTF(bfad, BFA_ERR,