Commit 464231fb authored Dec 21, 2015 by Linus Walleij

pinctrl: ssbi-gpio: Be sure to clamp return value



As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Also, this code was double-inverting a bool. That makes no
sense whatsoever, so I removed the double-invert.

Cc: Björn Andersson <bjorn.andersson@sonymobile.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 59663a4c

drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -487,10 +487,10 @@ static int pm8xxx_gpio_get(struct gpio_chip *chip, unsigned offset)
		} else {
		ret = irq_get_irqchip_state(pin->irq, IRQCHIP_STATE_LINE_LEVEL, &state);
		if (!ret)
		ret = !!state;
		ret = state;
		}

		return ret;
		return !!ret;
		}

		static void pm8xxx_gpio_set(struct gpio_chip *chip, unsigned offset, int value)