Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 45fd6c63 authored by Zhang Qilong's avatar Zhang Qilong Committed by Greg Kroah-Hartman
Browse files

staging: greybus: codecs: Fix reference counter leak in error handling 



[ Upstream commit 3952659a6108f77a0d062d8e8487bdbdaf52a66c ]

gb_pm_runtime_get_sync has increased the usage counter of the device here.
Forgetting to call gb_pm_runtime_put_noidle will result in usage counter
leak in the error branch of (gbcodec_hw_params and gbcodec_prepare). We
fixed it by adding it.

Fixes: c388ae76 ("greybus: audio: Update pm runtime support in dai_ops callback")
Signed-off-by: default avatarZhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201109131347.1725288-2-zhangqilong3@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent eab24ae7

drivers/staging/greybus/audio_codec.c

+2 −0
Original line number Diff line number Diff line
@@ -491,6 +491,7 @@ static int gbcodec_hw_params(struct snd_pcm_substream *substream, 
	if (ret) {

		dev_err_ratelimited(dai->dev, "%d: Error during set_config\n",

				    ret);

		gb_pm_runtime_put_noidle(bundle);

		mutex_unlock(&codec->lock);

		return ret;

	}
@@ -562,6 +563,7 @@ static int gbcodec_prepare(struct snd_pcm_substream *substream, 
		break;

	}

	if (ret) {

		gb_pm_runtime_put_noidle(bundle);

		mutex_unlock(&codec->lock);

		dev_err_ratelimited(dai->dev, "set_data_size failed:%d\n",

				     ret);