Commit 44af104e authored May 24, 2018 by Grigor Tovmasyan Committed by Greg Kroah-Hartman Aug 24, 2018

usb: gadget: dwc2: fix memory leak in gadget_init()



[ Upstream commit 9bb073a053f0464ea74a4d4c331fdb7da58568d6 ]

Freed allocated request for ep0 to prevent memory leak in case when
dwc2_driver_probe() failed.

Cc: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Acked-by: Minas Harutyunyan <hminas@synopsys.com>
Signed-off-by: Grigor Tovmasyan <tovmasya@synopsys.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 121621e7

drivers/usb/dwc2/gadget.c

+5 −2

Original line number	Original line	Diff line number	Diff line
	@@ -3948,9 +3948,11 @@ int dwc2_gadget_init(struct dwc2_hsotg *hsotg, int irq)
	}		}

	ret = usb_add_gadget_udc(dev, &hsotg->gadget);		ret = usb_add_gadget_udc(dev, &hsotg->gadget);
	if (ret)		if (ret) {
			dwc2_hsotg_ep_free_request(&hsotg->eps_out[0]->ep,
			hsotg->ctrl_req);
	return ret;		return ret;
			}
	dwc2_hsotg_dump(hsotg);		dwc2_hsotg_dump(hsotg);

	return 0;		return 0;
	@@ -3963,6 +3965,7 @@ int dwc2_gadget_init(struct dwc2_hsotg *hsotg, int irq)
	int dwc2_hsotg_remove(struct dwc2_hsotg *hsotg)		int dwc2_hsotg_remove(struct dwc2_hsotg *hsotg)
	{		{
	usb_del_gadget_udc(&hsotg->gadget);		usb_del_gadget_udc(&hsotg->gadget);
			dwc2_hsotg_ep_free_request(&hsotg->eps_out[0]->ep, hsotg->ctrl_req);

	return 0;		return 0;
	}		}