Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4494541c authored by Eyal Shapira's avatar Eyal Shapira Committed by Emmanuel Grumbach
Browse files

iwlwifi: mvm: rs: fix a theoretical access to uninitialized array elements 



Klocwork is unhappy as ht_vht_rates might be accessed with
rate->index being set to values between 0 and 3 which will
lead to accessing uninitialized array elements. Effectively this
doesn't happen as in HT/VHT we're not using these rate indices.
Still fix this.

Signed-off-by: default avatarEyal Shapira <eyalx.shapira@intel.com>
Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
parent a339e918

drivers/net/wireless/intel/iwlwifi/mvm/rs.c

+1 −0
Original line number Diff line number Diff line
@@ -556,6 +556,7 @@ static char *rs_pretty_rate(const struct rs_rate *rate) 
	if (is_type_legacy(rate->type) && (rate->index <= IWL_RATE_54M_INDEX))

		rate_str = legacy_rates[rate->index];

	else if ((is_type_ht(rate->type) || is_type_vht(rate->type)) &&

		 (rate->index >= IWL_RATE_MCS_0_INDEX) &&

		 (rate->index <= IWL_RATE_MCS_9_INDEX))

		rate_str = ht_vht_rates[rate->index];

	else