Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 444f9017 authored by Ulrich Weber's avatar Ulrich Weber Committed by Pablo Neira Ayuso
Browse files

netfilter: nf_conntrack_sip: extend request line validation 



on SIP requests, so a fragmented TCP SIP packet from an allow header starting with
 INVITE,NOTIFY,OPTIONS,REFER,REGISTER,UPDATE,SUBSCRIBE
 Content-Length: 0

will not bet interpreted as an INVITE request. Also Request-URI must start with an alphabetic character.

Confirm with RFC 3261
 Request-Line   =  Method SP Request-URI SP SIP-Version CRLF

Fixes: 30f33e6d ("[NETFILTER]: nf_conntrack_sip: support method specific request/response handling")
Signed-off-by: default avatarUlrich Weber <ulrich.weber@riverbed.com>
Acked-by: default avatarMarco Angaroni <marcoangaroni@gmail.com>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent dab45060

net/netfilter/nf_conntrack_sip.c

+4 −1
Original line number Diff line number Diff line
@@ -1436,9 +1436,12 @@ static int process_sip_request(struct sk_buff *skb, unsigned int protoff, 
		handler = &sip_handlers[i];

		if (handler->request == NULL)

			continue;

		if (*datalen < handler->len ||

		if (*datalen < handler->len + 2 ||

		    strncasecmp(*dptr, handler->method, handler->len))

			continue;

		if ((*dptr)[handler->len] != ' ' ||

		    !isalpha((*dptr)[handler->len+1]))

			continue;



		if (ct_sip_get_header(ct, *dptr, 0, *datalen, SIP_HDR_CSEQ,

				      &matchoff, &matchlen) <= 0) {