Commit 4401e487 authored Nov 20, 2012 by Sachin Kamat Committed by Bryan Wu Nov 26, 2012

leds: lp3944: Fix return value



Return the value obtained from i2c_smbus_read_byte_data() instead of
-EINVAL. Silences the following smatch warning:
drivers/leds/leds-lp3944.c:89 lp3944_reg_read() info:
why not propagate 'tmp' from i2c_smbus_read_byte_data() instead of -22?

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Bryan Wu <cooloney@gmail.com>

parent 5ebab74a

drivers/leds/leds-lp3944.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -86,7 +86,7 @@ static int lp3944_reg_read(struct i2c_client client, u8 reg, u8 value)

		tmp = i2c_smbus_read_byte_data(client, reg);
		if (tmp < 0)
		return -EINVAL;
		return tmp;

		*value = tmp;